Skip to content

Fixed Documentation bug in README #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

Fixed Documentation bug in README #78

merged 1 commit into from
Sep 24, 2021

Conversation

@naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Sep 22, 2021

Signed-off-by: Naveen Tatikonda [email protected]

Description

Fixed Documentation link in README file which is pointing to project website

Issues Resolved

#61

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB
Copy link
Member

VijayanB commented Sep 23, 2021

Can you add DEVELOPER_GUIDE and set documentation to https://opensearch.org/docs/clients/logstash/index/

@naveentatikonda
Copy link
Member Author

naveentatikonda commented Sep 23, 2021

Can you add DEVELOPER_GUIDE and set documentation to https://opensearch.org/docs/clients/logstash/index/

I will update documentation link which you mentioned. But, we already have DEVELOPER_GUIDE.

@VijayanB
Copy link
Member

VijayanB commented Sep 23, 2021

Can you add DEVELOPER_GUIDE and set documentation to https://opensearch.org/docs/clients/logstash/index/

I will update documentation link which you mentioned. But, we already have DEVELOPER_GUIDE.

Do we have link to Developer guide from READMe?

@naveentatikonda
Fixed Documentation bug in README
5214dec 
Signed-off-by: Naveen Tatikonda <[email protected]>
@naveentatikonda
Copy link
Member Author

naveentatikonda commented Sep 23, 2021

Can you add DEVELOPER_GUIDE and set documentation to https://opensearch.org/docs/clients/logstash/index/

I will update documentation link which you mentioned. But, we already have DEVELOPER_GUIDE.

Do we have link to Developer guide from READMe?

Added the link

@stockholmux stockholmux mentioned this pull request Sep 24, 2021
Closed
1 task
@naveentatikonda naveentatikonda merged commit 3053b39 into opensearch-project:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei

1 more reviewer

@VijayanB VijayanB VijayanB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naveentatikonda @VijayanB